Conversation
github-actions
bot
added
10.rebuild-darwin: 1
marcin-serwin
force-pushed
the
push-yxtssnqvzxvl
branch
from
284f884 to
6db2df1
Compare
pkgs/by-name/pl/plutosvg/package.nix
Outdated
There was a problem hiding this comment.
Why do we have to add two pkg-config validator?
There was a problem hiding this comment.
validatePkgConfig checks whether .pc file is syntactically correct, while testMetaPkgConfig checks that it exports the modules listed in meta.pkgConfigModules.
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin
force-pushed
the
push-yxtssnqvzxvl
branch
from
6db2df1 to
f4af63c
Compare
|
There was a problem hiding this comment.
- Needed for newer PCSX2
- Optional for sdl3-ttf (disabled at )
files LGTM:
╭─pedrohlc at desktop in /home/pedrohlc/.cache/nixpkgs-review/pr-410666
╰─λ find results/plutosvg.dev-x86_64-linux/ -type f
results/plutosvg.dev-x86_64-linux/nix-support/propagated-build-inputs
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgTargets-release.cmake
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgConfigVersion.cmake
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgConfig.cmake
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgTargets.cmake
results/plutosvg.dev-x86_64-linux/lib/pkgconfig/plutosvg.pc
results/plutosvg.dev-x86_64-linux/include/plutosvg/plutosvg.h
results/plutosvg.dev-x86_64-linux/include/plutosvg/plutosvg-ft.h
╭─pedrohlc at desktop in /home/pedrohlc/.cache/nixpkgs-review/pr-410666
╰─λ find results/plutosvg-x86_64-linux/ -type f
results/plutosvg-x86_64-linux/lib/libplutosvg.so.0
``
PedroHLC
added
the
12.approvals: 1
|
|
||
| patches = [ | ||
| # https://github.com/sammycage/plutosvg/pull/29 | ||
| ./0001-Emit-correct-pkg-config-file-if-paths-are-absolute.patch |
There was a problem hiding this comment.
I apologize for not seeing this before, trying to use it I get:
> Imported target "plutosvg::plutosvg" includes non-existent path
>
> "/nix/store/jk7v5dwymmbj81i2qbmc2c1c2k5csfpn-plutosvg-0.0.7/include/plutosvg"
>
> in its INTERFACE_INCLUDE_DIRECTORIES.
in that output, there is only one file:
╰─λ find /nix/store/jk7v5dwymmbj81i2qbmc2c1c2k5csfpn-plutosvg-0.0.7 -type f
/nix/store/jk7v5dwymmbj81i2qbmc2c1c2k5csfpn-plutosvg-0.0.7/lib/libplutosvg.so.0
``
There was a problem hiding this comment.
I have also noticed this issue, it is already fixed upstream with sammycage/plutosvg#31. I was planning to add it as a patch with the PR updating pcsx2 but I can create a separate PR earlier if you need it.
There was a problem hiding this comment.
No need @marcin-serwin, I've added a postInstall fix. Good work!
3 participants
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.